ci: fix invalid 'ctest --build' invocation#68
Merged
Conversation
--build is a cmake flag, not a ctest one ("CMake Error: Unknown argument:
--build"); the actual build already happens in the preceding step via
cmake --build. This was failing the "Ubuntu GCC DBG" job outright, and
via this workflow's fail-fast matrix strategy, cancelling every other
job in the run (including the -Werror builds, which otherwise compile
cleanly) before they could report their own real status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Run API tests" step in `main.yml` calls `ctest --build . --parallel 2 -C ... -V`, but `--build` is a `cmake` flag, not a `ctest` one:
```
CMake Error: Unknown argument: --build
CMake Error: Run 'ctest --help' for all supported options.
```
The actual build already happens in the preceding "Build/Install" step via `cmake --build`. This was failing the `Ubuntu GCC DBG` job outright on every run, and - via this workflow's fail-fast matrix strategy - cancelling every other job in the same run before they could report their own real status. Confirmed this includes the `-Werror` builds, which actually compile cleanly (100% of targets built) when allowed to run to completion.
Test plan
ctest --parallel 2 -C <mode> -V) to confirm it's validctestusage.Ubuntu GCC DBGjob and lets the rest of the matrix report real results.